Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modal] Fix to defer setting of exited state to Transition component #15266

Merged
merged 7 commits into from
Apr 11, 2019
Merged

[Modal] Fix to defer setting of exited state to Transition component #15266

merged 7 commits into from
Apr 11, 2019

Conversation

Sharakai
Copy link
Contributor

@Sharakai Sharakai commented Apr 8, 2019

Fixes #15180 (Modal aspect)

This is the follow-up PR for Modal of #15250, raised for @oliviertassinari to see the current progress and subsequent test failures.

@oliviertassinari oliviertassinari self-assigned this Apr 8, 2019
@mui-pr-bot
Copy link

mui-pr-bot commented Apr 8, 2019 •
edited
Loading

Details of bundle changes.

Comparing: 1fa8f94...bcde044

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core 0.00% 0.00% 347,568 347,576 89,893 89,893
@material-ui/core/Paper 0.00% 0.00% 68,404 68,404 20,053 20,053
@material-ui/core/Paper.esm 0.00% +0.01% 🔺 60,735 60,735 18,785 18,787
@material-ui/core/Popper 0.00% 0.00% 34,930 34,930 11,917 11,917
@material-ui/core/styles/createMuiTheme 0.00% 0.00% 17,877 17,877 5,962 5,962
@material-ui/core/useMediaQuery 0.00% 0.00% 2,463 2,463 1,044 1,044
@material-ui/lab 0.00% +0.01% 🔺 148,119 148,119 43,913 43,916
@material-ui/styles 0.00% 0.00% 53,143 53,143 15,443 15,443
@material-ui/system 0.00% 0.00% 17,132 17,132 4,519 4,519
Button 0.00% +0.02% 🔺 88,669 88,669 26,423 26,429
Modal +0.01% 🔺 -0.04% 82,688 82,696 24,802 24,793
colorManipulator 0.00% 0.00% 3,745 3,745 1,537 1,537
docs.landing 0.00% 0.00% 49,820 49,820 10,807 10,807
docs.main 0.00% -0.00% 644,630 644,654 200,877 200,875
packages/material-ui/build/umd/material-ui.production.min.js -0.00% -0.00% 296,257 296,255 82,811 82,808

Generated by 🚫 dangerJS against bcde044

@oliviertassinari oliviertassinari removed their assignment Apr 8, 2019
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: modal This is the name of the generic UI component, not the React module! labels Apr 9, 2019
@oliviertassinari oliviertassinari marked this pull request as ready for review April 10, 2019 12:47
@oliviertassinari oliviertassinari self-assigned this Apr 10, 2019
@oliviertassinari
Copy link
Member

oliviertassinari commented Apr 10, 2019 •
edited
Loading

@Sharakai Thank you! I have changed the test strategy. The test was passing with the next branch. I have written something high level that matches your codesandbox. It fails on next and passes on this branch.

@oliviertassinari oliviertassinari removed their assignment Apr 10, 2019
@eps1lon eps1lon mentioned this pull request Apr 11, 2019
Merged
1 task
@oliviertassinari oliviertassinari merged commit 72796e2 into mui:next Apr 11, 2019
@oliviertassinari oliviertassinari mentioned this pull request Apr 17, 2019
Closed
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari left review comments

@eps1lon eps1lon eps1lon approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: modal This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sharakai @mui-pr-bot @oliviertassinari @eps1lon